Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc minor fixes #617

Merged
merged 4 commits into from
Dec 6, 2024
Merged

misc minor fixes #617

merged 4 commits into from
Dec 6, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Apr 26, 2024 •
edited
Loading

  • fix float comparison to use isclose instead of exact equality
  • Allow astropy Quantities in calc_datacube wavelengths
  • delete unnecessary subdir and text file
  • Update docs conf.py for consistency with other packages, and clean up some docs formatting

@mperrin mperrin marked this pull request as ready for review December 6, 2024 19:18
@mperrin mperrin changed the title misc minor fixes (work in progress) misc minor fixes Dec 6, 2024
BradleySappington
BradleySappington approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradleySappington BradleySappington merged commit 7b53895 into spacetelescope:develop Dec 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradleySappington BradleySappington BradleySappington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mperrin @BradleySappington